Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.31.1] [Cherry-pick 651] Change dependency config in awsagentprovider #653

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

bjrara
Copy link
Member

@bjrara bjrara commented Dec 14, 2023

Issue #, if available:
fixed #648, #644 in v1.31.x.

Description of changes:
In this PR, we changed the dependency configuration of io.opentelemetry:opentelemetry-exporter-otlp from implementation to compileOnly.

The high cardinality issue was caused by introducing this dependency as implementation which causes classpath conflict during the runtime.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bjrara bjrara requested a review from a team as a code owner December 14, 2023 19:44
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e49186) 49.96% compared to head (1fc22a4) 49.96%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/v1.31.x     #653   +/-   ##
==================================================
  Coverage              49.96%   49.96%           
  Complexity               264      264           
==================================================
  Files                     39       39           
  Lines                   1297     1297           
  Branches                 145      145           
==================================================
  Hits                     648      648           
  Misses                   617      617           
  Partials                  32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bjrara bjrara changed the title [v1.31.1] Change dependency config in awsagentprovider [v1.31.1] [Cherry-pick 651] Change dependency config in awsagentprovider Dec 14, 2023
@bryan-aguilar bryan-aguilar merged commit d1061a9 into aws-observability:release/v1.31.x Dec 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants