Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.31.1] [Cherry-pick 646] E2E Testing: Add concurrency tag to test in main build and nightly build #654

Closed

Conversation

bjrara
Copy link
Member

@bjrara bjrara commented Dec 14, 2023

Issue #, if available:
None

Description of changes:
Cherry-pick #646 to v1.31.x

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…ild (aws-observability#646)

# Conflicts:
#	.github/workflows/nightly-upstream-snapshot-build.yml
@bjrara bjrara requested a review from a team as a code owner December 14, 2023 20:00
@bjrara bjrara changed the title [Cherry-pick 646] E2E Testing: Add concurrency tag to test in main build and nightly build [v1.31.1] [Cherry-pick 646] E2E Testing: Add concurrency tag to test in main build and nightly build Dec 14, 2023
Comment on lines +101 to +103
concurrency:
group: e2e-adot-test
cancel-in-progress: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The E2E test call is missing here, so the concurrency tag that is meant for it is going into the wrong part of the workflow. Compare with main to see the desired e2e test workflow call, not sure which commits are needed for that.

@bryan-aguilar
Copy link
Contributor

Not applicable on v1.31.x

@bjrara bjrara deleted the appsignals-e2e branch December 14, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants