Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Enablement Script from Github Repo Instead of S3 #655

Closed
wants to merge 3 commits into from
Closed

Download Enablement Script from Github Repo Instead of S3 #655

wants to merge 3 commits into from

Conversation

harrryr
Copy link
Contributor

@harrryr harrryr commented Dec 14, 2023

Issue #, if available:
The latest scripts for App Signals Enablement are now located in this repo.

Description of changes:
Replace the code downloading the enablement scripts from the S3 Bucket and download the scripts directly from the github repository instead.

Also remove the change ADOT image if main-build step, outdated code.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@harrryr harrryr requested a review from a team as a code owner December 14, 2023 23:30
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f5fc3b3) 50.73% compared to head (7b47778) 50.73%.
Report is 2 commits behind head on main.

❗ Current head 7b47778 differs from pull request most recent head 3cb11b2. Consider uploading reports for the commit 3cb11b2 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #655   +/-   ##
=========================================
  Coverage     50.73%   50.73%           
  Complexity      264      264           
=========================================
  Files            39       39           
  Lines          1301     1301           
  Branches        141      141           
=========================================
  Hits            660      660           
  Misses          609      609           
  Partials         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@majanjua-amzn
Copy link
Contributor

Can we do a test run?

@harrryr harrryr closed this by deleting the head repository Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants