Attempt to fix test_urls_excluded_from_sampling #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thpierce
changed the title
jj22ee
approved these changes
Apr 12, 2024
jj22ee
added a commit
to jj22ee/aws-otel-python-instrumentation
that referenced
this pull request
Jun 4, 2024
…ility#158)" This reverts commit 5586e87.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_urls_excluded_from_samplingkeeps failing on PR, causing annoying delays. I suspect that the problem is a race condition - we are exporting a span then grabbing it, and I believe that the delay between export and being "grabbable" is causing the test to fail (typically with1 != 2). As an attempted fix, I'm adding some retry logic that will attempt to grab for a full second.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.