Replace Dockerfile with busybox as the base image #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrryr
force-pushed
the
update-dockerfile
branch
from
a232099 to
ab73636
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Currently amazon linux is used as the base image for OTEL python distribution. This image contains a lot of unnecessary packages that inflate the image and also cause issues during high sev scans. Ideally we would like to use an image with minimal content.
Scratchwas the base image that was initially proposed to be used withcpUtilityinstalled to enable thecpcommand to copy the python image to the Opentelemetry operator volume. However, upon testing, although application signals was started without any issues, no telemetries were generated. (Failed Test).Alternatively,
busyboxwas used as the base image and was able to run application signals successfully.busyboxis an image with common UNIX utilities installed and < 2MB in size.Final size comparison:
Test run: https://github.com/aws-observability/aws-otel-python-instrumentation/actions/runs/9090440702
Note: Test run above is failing in the trace validation step due to a bug in the way the release testing is ran for this repository. Verified that telemetry is generated with proper traces. Will be fixed in subsequent PR
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.