-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code style and error check. #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For each of the tools used here, I'd like to see them fail, to prove they work. So I want to see:
- codespell identify a typo
- flake8 find a style violation
- isort clean up an import
- pylint find a style violation
Any others I missed.
I tests these functionality in my forked repo, please find each of them using the link below:
|
…date README for code style check and unit test.
This PR add the code syntax and error check for the whole repo by following the same principle of opentelemetry-python-contrib and use the following tools:
codespell: Find and fix common spelling mistakes.
flake8 and black: Code style check and code formatting.
Isort: Adjust the import statements.
pylint: Configures pylint's style check rules, ignores specific warnings and statements, defines naming conventions, format logging style and spelling, etc,.