Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin setuptools version to 75.2.0 #311

Merged
merged 2 commits into from
Jan 9, 2025
Merged

pin setuptools version to 75.2.0 #311

merged 2 commits into from
Jan 9, 2025
+4 −2

Conversation

yiyuan-he
Copy link
Contributor

@yiyuan-he yiyuan-he commented Jan 9, 2025 •
edited
Loading

Issue #, if available:
We found another issue with a dependency (setuptools) dropping Python 3.8 support.

Dependency issue with urllib3 PR.

  File "/otel-auto-instrumentation-python/opentelemetry/instrumentation/auto_instrumentation/__init__.py", line 22, in <module>
    from pkg_resources import iter_entry_points
  File "<frozen importlib._bootstrap>", line 991, in _find_and_load
  File "<frozen importlib._bootstrap>", line 975, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 671, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 843, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/otel-auto-instrumentation-python/pkg_resources/__init__.py", line 25, in <module>
    raise RuntimeError("Python 3.9 or later is required")
RuntimeError: Python 3.9 or later is required

https://github.com/pypa/setuptools/blame/main/pkg_resources/__init__.py#L24

Description of changes:
Pinned most recent compatible version of setuptools in our pyproject.toml.

Test plan:
Pushed this fixed version of SDK to an ECR repo and tested in the playground cluster to confirm the runtime errors are resolved.

❯ kubectl get pods

NAME                      READY   STATUS        RESTARTS   AGE
my-app-5c5c6b949f-htjj2   1/1     Running       0          7s
my-app-5c5c6b949f-zk9nn   1/1     Running       0          7s
my-app-76fbfbd7fc-mb4ft   1/1     Terminating   0          7m12s
my-app-76fbfbd7fc-tpql7   1/1     Terminating   0          7m12s

appsignals_django_uwsgi_sample/myproject on  main [?] via  desktop-linux via  v3.8.18 on   (us-east-1)
❯ kubectl logs my-app-5c5c6b949f-htjj2
Defaulted container "my-container" out of: my-container, opentelemetry-auto-instrumentation-python (init)
AwsEcsResourceDetector failed: Missing ECS_CONTAINER_METADATA_URI therefore process is not on ECS.
AwsEksResourceDetector failed: HTTP Error 403: Forbidden
Configuration of configurator not loaded, aws_configurator already loaded
('Could not find the ORIG_HANDLER or _HANDLER in the environment variables. ', 'This instrumentation requires the OpenTelemetry Lambda extension installed.')
Operations to perform:
  Apply all migrations: admin, auth, contenttypes, sessions
Running migrations:
  Applying contenttypes.0001_initial... OK
  Applying auth.0001_initial... OK
  Applying admin.0001_initial... OK
  Applying admin.0002_logentry_remove_auto_add... OK
  Applying admin.0003_logentry_add_action_flag_choices... OK
  Applying contenttypes.0002_remove_content_type_name... OK
  Applying auth.0002_alter_permission_name_max_length... OK
  Applying auth.0003_alter_user_email_max_length... OK
  Applying auth.0004_alter_user_username_opts... OK
  Applying auth.0005_alter_user_last_login_null... OK
  Applying auth.0006_require_contenttypes_0002... OK
  Applying auth.0007_alter_validators_add_error_messages... OK
  Applying auth.0008_alter_user_username_max_length... OK
  Applying auth.0009_alter_user_last_name_max_length... OK
  Applying auth.0010_alter_group_name_max_length... OK
  Applying auth.0011_update_proxy_permissions... OK
  Applying auth.0012_alter_user_first_name_max_length... OK
  Applying sessions.0001_initial... OK
AwsEcsResourceDetector failed: Missing ECS_CONTAINER_METADATA_URI therefore process is not on ECS.
AwsEksResourceDetector failed: HTTP Error 403: Forbidden
Configuration of configurator not loaded, aws_configurator already loaded
('Could not find the ORIG_HANDLER or _HANDLER in the environment variables. ', 'This instrumentation requires the OpenTelemetry Lambda extension installed.')

125 static files copied to '/django_frontend_app/static'.
AwsEcsResourceDetector failed: Missing ECS_CONTAINER_METADATA_URI therefore process is not on ECS.
AwsEksResourceDetector failed: HTTP Error 403: Forbidden
Configuration of configurator not loaded, aws_configurator already loaded
('Could not find the ORIG_HANDLER or _HANDLER in the environment variables. ', 'This instrumentation requires the OpenTelemetry Lambda extension installed.')
Performing system checks...

System check identified no issues (0 silenced).
January 09, 2025 - 19:28:09
Django version 4.2.16, using settings 'django_frontend_service.settings'
Starting development server at http://0.0.0.0:8000/
Quit the server with CONTROL-C.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yiyuan-he yiyuan-he requested a review from a team as a code owner January 9, 2025 19:35
@yiyuan-he yiyuan-he mentioned this pull request Jan 9, 2025
Merged
mxiamxia pushed a commit to aws-observability/aws-application-signals-test-framework that referenced this pull request Jan 9, 2025
@yiyuan-he
Revert "pin urllib3 version in sample app (#349)" (#350)
5ee537b 
This reverts commit 4d358c7.

*Issue description:*
Root cause was found to be another dependency dropping support for
python 3.8. This change is no longer needed.

More context
[here](aws-observability/aws-otel-python-instrumentation#311).

*Description of changes:*

*Rollback procedure:*

<Can we safely revert this commit if needed? If not, detail what must be
done to safely revert and why it is needed.>

*Ensure you've run the following tests on your changes and include the
link below:*

To do so, create a `test.yml` file with `name: Test` and workflow
description to test your changes, then remove the file for your PR. Link
your test run in your PR description. This process is a short term
solution while we work on creating a staging environment for testing.

NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL.
See the
[needs](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idneeds)
keyword to run tests in succession.
- Run Java EKS on `e2e-playground` in us-east-1 and eu-central-2
- Run Python EKS on `e2e-playground` in us-east-1 and eu-central-2
- Run metric limiter on EKS cluster `e2e-playground` in us-east-1 and
eu-central-2
- Run EC2 tests in all regions
- Run K8s on a separate K8s cluster (check IAD test account for master
node endpoints; these will change as we create and destroy clusters for
OS patching)

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
@yiyuan-he yiyuan-he merged commit aaa458b into aws-observability:main Jan 9, 2025
12 checks passed
@yiyuan-he yiyuan-he deleted the pin-setuptools-version branch January 9, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxiamxia mxiamxia mxiamxia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yiyuan-he @mxiamxia