Support configurable interval to send TCP keepalive probes + Change to use port 80 as sample instead of port 8000 + Upgrade to v2.0.1 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue is related to axum-server: Give more control on connection tasks #29 |
Change to use port 80 as sample instead of port 8000 + Make use of structured data in logging + Upgrade to v2.0.1 #4
nigamaviral
reviewed
Sep 13, 2022
| pub struct ServerConfig { | ||
| pub ip: String, | ||
| pub port: u16, | ||
| pub region: String, | ||
| pub service: String, | ||
| pub ciphertext_metadata_b64: Option<String>, | ||
| // https://stackoverflow.com/questions/70184303/how-to-serialize-and-deserialize-chronoduration |
There was a problem hiding this comment.
is there any issues with adding stack overflow links ?
There was a problem hiding this comment.
I don't think so. This is open source and it's helpful to provide the source of info.
nigamaviral
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
I recently observed the following error when running the xks-proxy against a CloudHSM:
Using
lsof, I sawApparently, the tcp keep-alive timeout is disabled by default in hyper:
Description of changes:
Testing:
Testing with a 60 second interval to send TCP keepalive probes is in progress.
Will see if this change actually fixes the issue by running the patched server on the host that exhibited this failure before for a day or two.
watch `sudo lsof -p 129360 | grep TCP | grep ESTABLISHED | wc -l && sudo lsof -p 129360 | grep TCP | sort -k9 | grep ESTABLISHED`By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.