Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fixes, Visual Improvement, Performance Improvement, and WATools integration #152

Merged
merged 16 commits into from
Oct 24, 2024

Conversation

kuettai
Copy link
Contributor

@kuettai kuettai commented Oct 24, 2024

Description

Bug Fixes, Visual Improvement, Performance Improvement, and WATools integration

Type of change

Please delete options that are not relevant, and add any that may be relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • CrossAccounts, Multiple Services and Multiple Regions

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested this change with all regions and services

@kuettai kuettai merged commit 3d55ed3 into aws-samples:main Oct 24, 2024
1 check passed
@@ -25,6 +31,9 @@

def checkIsPrivateIp(ipaddr):
ip = ipaddr.split('/')
if ip[0] == '0.0.0.0':

Check warning

Code scanning / Bandit

Possible binding to all interfaces. Warning

Possible binding to all interfaces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant