Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues #69 and #70 #71

Merged
merged 3 commits into from
Apr 8, 2024
Merged

Fix issues #69 and #70 #71

merged 3 commits into from
Apr 8, 2024

Conversation

kuettai
Copy link
Contributor

@kuettai kuettai commented Apr 8, 2024

Description

1/ Update missing information in KMS.reporter
2/ Update readme.md to reflects to use --tags instead of --filters.

Fixes #69, #70

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Single Account, Single Service and Single Region
  • Single Account, Single Service and Multiple Regions
  • Single Account, Multiple Services and Single Region
  • Single Account, Multiple Services and Multiple Regions

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have tested this change with all regions and services

@kuettai kuettai merged commit 229462f into aws-samples:main Apr 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule kms::DisabledKey is not available in reporter
1 participant