Skip to content

Commit

Permalink
Merge pull request #19 from gockle/main
Browse files Browse the repository at this point in the history
Update NodeJS version in CodeBuild Stage to 18
  • Loading branch information
aijunpeng authored Nov 9, 2023
2 parents 801b365 + 012dfa3 commit 81751bb
Show file tree
Hide file tree
Showing 8 changed files with 130 additions and 126 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [1.0.4] - 2023-11-10

- Update NodeJS environment for CodeBuild from NodeJS16 to NodeJS18.

## [1.0.3] - 2023-10-27

### Changed
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,11 @@ [email protected] with any additional questions or comments.


## Security issue notifications
If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our [vulnerability reporting page](http://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public github issue.
If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our [vulnerability reporting page](https://aws.amazon.com/security/vulnerability-reporting/). Please do **not** create a public github issue.


## Licensing

See the [LICENSE](https://github.com/aws-solutions/firewall-automation-for-network-traffic-on-aws/blob/main/LICENSE.txt) file for our project's licensing. We will ask you to confirm the licensing of your contribution.

We may ask you to sign a [Contributor License Agreement (CLA)](http://en.wikipedia.org/wiki/Contributor_License_Agreement) for larger changes.
We may ask you to sign a [Contributor License Agreement (CLA)](https://en.wikipedia.org/wiki/Contributor_License_Agreement) for larger changes.
2 changes: 1 addition & 1 deletion solution-manifest.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
id: SO0108 # Solution Id
name: firewall-automation-for-network-traffic-on-aws # trademarked name
version: v1.0.3 # current version of the solution. Used to verify template headers
version: v1.0.4 # current version of the solution. Used to verify template headers
cloudformation_templates: # This list should match with AWS CloudFormation templates section of IG
- template: firewall-automation-for-network-traffic-on-aws.template
main_template: true
Expand Down
8 changes: 4 additions & 4 deletions source/lib/network-firewall-automation-solution-stack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ export class NetworkFirewallAutomationStack extends Stack {
phases: {
install: {
'runtime-versions': {
nodejs: '16',
nodejs: '18',
},
commands: [`export current=$(pwd)`, `export sourceCodeKey=$CODE_BUILD_SOURCE_CODE_S3_KEY`],
},
Expand All @@ -676,7 +676,7 @@ export class NetworkFirewallAutomationStack extends Stack {
},
}),
environment: {
buildImage: LinuxBuildImage.STANDARD_6_0,
buildImage: LinuxBuildImage.STANDARD_7_0,
},
environmentVariables: codeBuildEnvVariables,
});
Expand Down Expand Up @@ -911,7 +911,7 @@ export class NetworkFirewallAutomationStack extends Stack {
phases: {
install: {
'runtime-versions': {
nodejs: '16',
nodejs: '18',
},
commands: [`export current=$(pwd)`, `export sourceCodeKey=$CODE_BUILD_SOURCE_CODE_S3_KEY`],
},
Expand All @@ -937,7 +937,7 @@ export class NetworkFirewallAutomationStack extends Stack {
},
}),
environment: {
buildImage: LinuxBuildImage.STANDARD_6_0,
buildImage: LinuxBuildImage.STANDARD_7_0,
},
environmentVariables: codeBuildEnvVariables,
});
Expand Down
116 changes: 58 additions & 58 deletions source/networkFirewallAutomation/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion source/networkFirewallAutomation/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@types/uuid": "^9.0.6",
"aws-sdk-mock": "^5.1.0",
"@types/jest": "~29.5.5",
"@types/node": "^20.6.5",
"@types/node": "^20.9.0",
"jest": "~29.7.0",
"ts-jest": "~29.1.1",
"ts-node": "~10.9.1",
Expand Down
Loading

0 comments on commit 81751bb

Please sign in to comment.