Adding Logs Only Windows Test #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefchien
approved these changes
Sep 15, 2023
|
Please change the name of the PR. This isn't adding a duplicate log test. It's adding a logs only windows test case. |
okankoAMZ
changed the title
zhihonl
reviewed
Sep 15, 2023
zhihonl
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Currently when we have only logs in windows we get duplicate logs. This test handles that case and catches it.
Description of changes
This test creates a terraform instance and runs CWA with only log then check for duplicate logs.
Note
This test right now currently fails, which is intentional since the fix for this case has not been merged yet.
Succesfuly run:
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Ran the test and checked logs
Successful run