Add EMF concurrency test to check for log corruption. #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movence
reviewed
Sep 26, 2023
sethAmazon
reviewed
Sep 26, 2023
sethAmazon
reviewed
Sep 26, 2023
sethAmazon
previously approved these changes
Sep 26, 2023
adam-mateen
reviewed
Sep 26, 2023
adam-mateen
reviewed
Sep 26, 2023
adam-mateen
reviewed
Sep 26, 2023
| } | ||
| } | ||
|
|
||
| func (e *emitter) createEmfLog(metadata *Metadata) []byte { |
There was a problem hiding this comment.
Doesn't need to done now, but I can see this code to send EMF metrics being useful outside this test case.
Might want to move it to a UTIL at some point. I saw you mentioned there was no EMF package in go to do this... yikes.
adam-mateen
reviewed
Sep 26, 2023
movence
previously approved these changes
Sep 26, 2023
movence
approved these changes
Sep 26, 2023
sethAmazon
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
There was an issue with the TCP log receiver corrupting logs on high concurrency. This was fixed as part of amazon-contributing/opentelemetry-collector-contrib#72, but was not pulled into the agent until aws/amazon-cloudwatch-agent#857. This was undetected because it was verified using manual testing.
Description of changes
Add an EMF concurrency test that creates multiple TCP connections to the agent and writes to them concurrently. Runs a log query to determine if any of the logs were corrupted.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Failure from v1.300028.1 (aws/amazon-cloudwatch-agent@6b25891) run
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/6304504010/job/17116940882
Success from latest (aws/amazon-cloudwatch-agent@2a3fdf9) run
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/6305043334/job/17117674411