Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Format Of EKS EMF Assume Role #354

Closed
wants to merge 1 commit into from

Conversation

sethAmazon
Copy link
Contributor

Description of the issue

EKS emf test will not start for error

│ Error: "assume_role_policy" contains an invalid JSON policy: leading space characters are not allowed
│ 
│   with aws_iam_role.node_role,
│   on main.tf line 67, in resource "aws_iam_role" "node_role":
│   67:   assume_role_policy = <<POLICY
│   68:     {
│   69:       "Version": "2012-10-17",
│   70:       "Statement": [
│   71:         {
│   72:           "Effect": "Allow",
│   73:           "Principal": {
│   74:             "Service": "ec2.amazonaws.com"
│   75:           },
│   76:           "Action": "sts:AssumeRole"
│   77:         }
│   78:       ]
│   79:     }
│   80:     POLICY

Description of changes

Match the format given for other eks test assume role

  assume_role_policy = <<POLICY
{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Effect": "Allow",
      "Principal": {
        "Service": "ec2.amazonaws.com"
      },
      "Action": "sts:AssumeRole"
    }
  ]
}
POLICY
}

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

None

@sethAmazon sethAmazon requested a review from a team as a code owner October 4, 2023 01:49
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting that the format would change the result of the test...

Can you link an integration test run and verify that it fixes this issue?

@sethAmazon sethAmazon closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants