Updating EKSIntegration for Enhanced Container Insights #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchappa
reviewed
Oct 30, 2023
| "apiserver_request_total": {}, | ||
| "apiserver_request_total_5xx": {}, | ||
| "apiserver_admission_controller_admission_duration_seconds": {}, | ||
| "apiserver_admission_step_admission_duration_seconds", |
There was a problem hiding this comment.
Good catch, updated
| @@ -2,7 +2,8 @@ | |||
| "logs": { | |||
| "metrics_collected": { | |||
| "kubernetes": { | |||
| "metrics_collection_interval": 30 | |||
| "metrics_collection_interval": 30, | |||
| "enhanced_container_insights": true | |||
There was a problem hiding this comment.
Not going to block -- would it be better to have a separate test for enhanced_container_insights ?
There was a problem hiding this comment.
Will be addressed in a separate test which tests every observation
JayPolanco
approved these changes
Oct 30, 2023
dchappa
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Capture enhanced container insights metrics for EKSIntegrationTest
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/6685532283/job/18163971709