Add Windows Start Agent With EC2 Run Command #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethAmazon
commented
Nov 15, 2023
| targets: map[string]map[string]struct{}{"os": {"win-2019": {}}}, | ||
| }, | ||
| { | ||
| testDir: "../../../test/feature/windows/custom_start/ssm_start", |
There was a problem hiding this comment.
Since this is an exception case where we only need to test starting the agent with ssm commands, I think it is fine to only run on a single os.
There was a problem hiding this comment.
This is a sanity test the agent can start and get metrics.
sethAmazon
commented
Nov 15, 2023
| //runs validator and sets up prometheus java agent | ||
| provisioner "remote-exec" { | ||
| inline = [ | ||
| "set AWS_REGION=${var.region}", | ||
| "validator.exe --validator-config=${module.validator.instance_validator_config} --preparation-mode=true", | ||
| "powershell.exe \"& \"C:ProgramFiles\\Amazon\\AmazonCloudWatchAgent\\amazon-cloudwatch-agent-ctl.ps1\" -m ec2 -a status\"", | ||
| "powershell.exe \"& 'C:ProgramFiles\\Amazon\\AmazonCloudWatchAgent\\amazon-cloudwatch-agent-ctl.ps1' -m ec2 -a status\"", |
There was a problem hiding this comment.
You should not use double quotes here to get status check
sethAmazon
commented
Nov 15, 2023
| provisioner "remote-exec" { | ||
| inline = [ | ||
| "set AWS_REGION=${var.region}", | ||
| "aws ssm send-command --document-name AmazonCloudWatch-ManageAgent --parameters optionalConfigurationLocation=${local.ssm_parameter_name} --targets Key=tag:Name,Values=cwagent-integ-test-ec2-windows-${var.test_name}-${module.common.testing_id}", |
There was a problem hiding this comment.
ssm command to start the agent with the config file uploaded to ssm parameters
bhanuba
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
There is no test that tests starting the Cloudwatch agent with ssm commands on windows. This could be a problem since on windows it will fail if it logs to standard error on startup.
Description of changes
Add a test for starting the agent on windows with ssm commands.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/6882426811/job/18721347139
Integration tests