Jmx metrics #385
Merged
Jmx metrics #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethAmazon
commented
Jan 30, 2024
test/metric/metric_value_query.go
Outdated
| @@ -46,7 +46,7 @@ func (n *MetricValueFetcher) Fetch(namespace, metricName string, metricSpecificD | |||
| Period: &metricQueryPeriod, | |||
| Stat: aws.String(string(stat)), | |||
| }, | |||
| Id: aws.String(strings.ToLower(metricName)), | |||
| Id: aws.String(strings.ToLower(strings.ReplaceAll(metricName, ".", "_"))), | |||
There was a problem hiding this comment.
. not allowed in id
sethAmazon
commented
Jan 30, 2024
| @@ -119,6 +119,9 @@ | |||
| <Component Id='TranslatorEXE' Guid='f4527006-edcb-4271-a971-039848bc8bb7' Win64='yes'> | |||
| <File Source='config-translator.exe' KeyPath='yes' Checksum='yes'/> | |||
| </Component> | |||
| <Component Id='OtelJmxJar' Guid='5af08c39-c483-4b08-8315-c99345684c4d' Win64='yes'> | |||
There was a problem hiding this comment.
Required to add jar to msi
sethAmazon
commented
Jan 30, 2024
| } | ||
|
|
||
| log.Println("set up zookeeper and kafka") | ||
| startJMXCommands := []string{ |
There was a problem hiding this comment.
Start kafka, requires starting zookeeper
sethAmazon
commented
Jan 30, 2024
| @@ -157,5 +158,10 @@ func shouldRunEC2Test(env *environment.MetaData, t *test_runner.TestRunner) bool | |||
| } | |||
| _, shouldRun := env.EC2PluginTests[strings.ToLower(t.TestRunner.GetTestName())] | |||
| _, shouldExclude := env.ExcludedTests[strings.ToLower(t.TestRunner.GetTestName())] | |||
| return shouldRun || !shouldExclude | |||
| if shouldRun { | |||
There was a problem hiding this comment.
Fix issue with where include was adding all tests instead of only the tests in include
sethAmazon
force-pushed
the
jmx-metrics
branch
from
8b45a64 to
031cb01
Compare
sethAmazon
force-pushed
the
jmx-metrics
branch
from
031cb01 to
8ed2cbe
Compare
sethAmazon
force-pushed
the
jmx-metrics
branch
from
8ed2cbe to
b3834e4
Compare
sethAmazon
force-pushed
the
jmx-metrics
branch
4 times, most recently
from
becc77a to
2037bc2
Compare
sethAmazon
force-pushed
the
jmx-metrics
branch
8 times, most recently
from
b1fde3c to
a501535
Compare
Add opentelemetry-jmx-metrics.jar To MSI Add Tomcat JMX Metrics Tests
lisguo
approved these changes
May 29, 2024
| @@ -119,6 +120,9 @@ | |||
| <Component Id='TranslatorEXE' Guid='f4527006-edcb-4271-a971-039848bc8bb7' Win64='yes'> | |||
| <File Source='config-translator.exe' KeyPath='yes' Checksum='yes'/> | |||
| </Component> | |||
| <Component Id='OtelJmxJar' Guid='5af08c39-c483-4b08-8315-c99345684c4d' Win64='yes'> | |||
| <File Source='opentelemetry-jmx-metrics.jar' KeyPath='yes'/> | |||
There was a problem hiding this comment.
does this need to be changed to packaging/opentelemetry-jmx-metrics.jar?
There was a problem hiding this comment.
This comes from msi zip not the repo. The repo copies to msi zip by the pre package make command
mitali-salvi
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
No jmx metrics tests.
Description of changes
Add jmx metrics test to metric value benchmark test.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/7544852634/job/20735092549