Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macOS sonoma #395

Merged
merged 3 commits into from
Mar 5, 2024
Merged

add macOS sonoma #395

merged 3 commits into from
Mar 5, 2024

Conversation

ymtaye
Copy link
Contributor

@ymtaye ymtaye commented Mar 5, 2024

Description of the issue

No testing support for macOS Sonoma arm64 and x86_64

Description of changes

  • Add testing support for macOS Sonoma arm64 and x86_64

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Manual testing

x86_64

vtayyare@88665a54407b Downloads % ssh -i "test_macos.pem" [email protected]
Last login: Tue Mar  5 20:54:28 2024 from 205.251.233.236

    ┌───┬──┐   __|  __|_  )
    │ ╷╭╯╷ │   _|  (     /
    │  └╮  │  ___|\___|___|
    │ ╰─┼╯ │  Amazon EC2
    └───┴──┘  macOS Sonoma 14.3

ec2-user@ip-172-31-40-218 ~ % sudo /opt/aws/amazon-cloudwatch-agent/bin/amazon-cloudwatch-agent-ctl -a status
{
  "status": "running",
  "starttime": "2024-03-05T20:55:34+0000",
  "configstatus": "configured",
  "version": "1.300033.0b462"
}
Screenshot 2024-03-05 at 3 58 46 PM Screenshot 2024-03-05 at 3 57 10 PM

arm64

vtayyare@88665a54407b Downloads % ssh -i "test_macos.pem" [email protected]
Last login: Tue Mar  5 22:39:01 2024 from 205.251.233.176

    ┌───┬──┐   __|  __|_  )
    │ ╷╭╯╷ │   _|  (     /
    │  └╮  │  ___|\___|___|
    │ ╰─┼╯ │  Amazon EC2
    └───┴──┘  macOS Sonoma 14.3

ec2-user@ip-172-31-41-93 ~ % sudo /opt/aws/amazon-cloudwatch-agent/bin/amazon-cloudwatch-agent-ctl -a status
{
  "status": "running",
  "starttime": "2024-03-05T22:45:24+0000",
  "configstatus": "configured",
  "version": "1.300033.0b462"
}
ec2-user@ip-172-31-41-93 ~ %
Screenshot 2024-03-05 at 5 47 23 PM Screenshot 2024-03-05 at 5 52 36 PM

Integration testing

https://github.com/aws/amazon-cloudwatch-agent/actions/runs/8162039788

@ymtaye ymtaye requested a review from a team as a code owner March 5, 2024 22:53
@ymtaye ymtaye merged commit 3c62d6b into aws:main Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants