-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integ test for Nvidia GPU in EKS #399
Conversation
nit: TItle should be |
Can you link a full integration test run so we can check if it breaks existing tests |
Sure, added to the desc. There are some failures but they seem to be not related to gpu test changes. |
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/8542742082/job/23405557390 One of the |
Seeing timeouts with:
which doesn't seem to be related to this PR, but I will let the change owner know about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Description of changes
Add integ test for GPU with EKS. Highlights of this PR:
httpd
to mock dcgm exporter/metrics
endpoint with a static prometheus data file. All metric values are 1License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Integ test run: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/8542742082