Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metrics_collection_interval for Kafka to 10 seconds #413

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

okankoAMZ
Copy link
Contributor

@okankoAMZ okankoAMZ commented Jul 10, 2024

Description of the issue

Currently the metric_value_benchmark test is failing due to the increase in Kafka metrics to 60 seconds.

Description of changes

Modified test agent config to include "metrics_collection_interval": 10

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

It passed with 10 seconds interval in this integration test: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/9681807856/job/26713593403
And it started failing when we update to 60 seconds seen in this integration test:
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/9717891459/job/26825009743

@okankoAMZ okankoAMZ requested a review from a team as a code owner July 10, 2024 21:08
@jefchien jefchien merged commit e4f4c03 into main Jul 10, 2024
2 checks passed
@jefchien jefchien deleted the okankoAMZ-patch-1 branch July 10, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants