-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integ test for Amazon Managed Prometheus as destination #414
Conversation
test/amp/agent_configs/config.json
Outdated
"*" | ||
], | ||
"drop_original_metrics": [ | ||
"usage_iowait", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to drop these two metrics?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment is can we make the test name bit more descriptive than AmpTest
. It feels like it will be hard to distinguish in the long run
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
const ( | ||
namespace = "AMPDestinationTest" | ||
// template prometheus query for getting average of 3 min | ||
ampQueryTemplate = "avg_over_time(%s%s[3m])" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using PromQL function avg_over_time
for last 3m https://prometheus.io/docs/prometheus/latest/querying/functions/#aggregation_over_time
Depends on aws/amazon-cloudwatch-agent#1192
Description of changes
Add integ test for Amazon Managed Prometheus as destination.
New AMP integ test:
test/amp
is usedCPU
andProcess
plugins to emit and validate metricsappend_dimensions
(both metric and global level),rename
andaggregation_dimensions
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Test run: