Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add removed variables for ami_type and instance_type #420

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

aditya-purang
Copy link
Contributor

@aditya-purang aditya-purang commented Aug 22, 2024

Description of the issue

We had removed the ami_type and instance_type variables from the variables.tf file since they were not used but the terraform apply in the agent needs these variables, adding them back so that the terraform apply doesn't fail

agent code :

terraform init
            if terraform apply --auto-approve \
              -var="test_dir=${{ matrix.arrays.test_dir }}"\
              -var="cwagent_image_repo=${{ steps.login-ecr.outputs.registry }}/${{ env.ECR_INTEGRATION_TEST_REPO }}" \
              -var="cwagent_image_tag=${{ github.sha }}" \
              -var="ami_type=${{ matrix.arrays.ami }}" \
              -var="instance_type=${{ matrix.arrays.instanceType }}" \
              -var="k8s_version=${{ matrix.arrays.k8s_version }}"; then
              terraform destroy -auto-approve
            else
              terraform destroy -auto-approve && exit 1
            fi

Description of changes

  • adding back ami_type and instance_type in neuron integ test

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

@aditya-purang aditya-purang marked this pull request as ready for review August 22, 2024 13:25
@aditya-purang aditya-purang requested a review from a team as a code owner August 22, 2024 13:25
@movence movence merged commit 76daeab into aws:main Aug 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants