Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #422

Merged
merged 2 commits into from
Oct 4, 2024
Merged

Fix typos #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8f66de
Update test matrix to be in version order
varunch77 Oct 4, 2024
67aa2e3
Fix typos in doc
varunch77 Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/license-manager-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ License manager requires a license to manage all the dedicated hosts own by a ac
5. Provide `License name` and choose `Cores` for `Licence Type`. Leave the `Number of Cores` empty for default value and click `Submit`

# 2. Associate AMI for license
In order launch dedicated host instances using License Manager, we have to associate AMI with the license we created. Note that we must own the AMI so to work around this we can copy existing AMI.
In order to launch dedicated host instances using License Manager, we have to associate AMI with the license we created. Note that we must own the AMI so to work around this we can copy existing AMI.
1. Go to EC2 page
2. Click on `AMIs` on the sidebar
3. Filter by `Public Images` and select the AMI you want to copy
Expand All @@ -24,7 +24,7 @@ In order launch dedicated host instances using License Manager, we have to assoc
Host resource group manages the host associated with the server-bound licenses and this is the group we will call to help us access available dedicated hosts
1. Go to AWS License Manager
2. Click on `Host resource groups` on the sidebar
3. Click on `Create sost resource groups`
3. Click on `Create host resource groups`
4. Provide `Host resource group name`, deselect `Release hosts automatically`, and use the license you created in step 1 for section `Associated self-managed licenses`
5. Click on `Create`

Expand All @@ -46,7 +46,7 @@ resource "aws_instance" "cwagent" {
associate_public_ip_address = true
instance_initiated_shutdown_behavior = "terminate"
tenancy = "host"
host_resource_group_arn = your_host_resourc_group_arn
host_resource_group_arn = your_host_resource_group_arn

metadata_options {
http_endpoint = "enabled"
Expand Down
16 changes: 8 additions & 8 deletions generator/resources/ec2_mac_test_matrix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,26 @@
[
{
"os": "macOS Ventura Arm64",
"os": "macOS Monterey Arm64",
"instanceType":"mac2.metal",
"ami": "cloudwatch-agent-integration-test-mac-ventura-arm64",
"ami": "cloudwatch-agent-integration-test-mac-monterey-arm64",
"arc": "arm64"
},
{
"os": "macOS Ventura Amd64",
"os": "macOS Monterey Amd64",
"instanceType":"mac1.metal",
"ami": "cloudwatch-agent-integration-test-mac-ventura-x86",
"ami": "cloudwatch-agent-integration-test-mac-monterey-x86",
"arc": "amd64"
},
{
"os": "macOS Monterey Arm64",
"os": "macOS Ventura Arm64",
"instanceType":"mac2.metal",
"ami": "cloudwatch-agent-integration-test-mac-monterey-arm64",
"ami": "cloudwatch-agent-integration-test-mac-ventura-arm64",
"arc": "arm64"
},
{
"os": "macOS Monterey Amd64",
"os": "macOS Ventura Amd64",
"instanceType":"mac1.metal",
"ami": "cloudwatch-agent-integration-test-mac-monterey-x86",
"ami": "cloudwatch-agent-integration-test-mac-ventura-x86",
"arc": "amd64"
},
{
Expand Down
Loading