-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EKS integration test for FluentBit log emission with Entity field #427
Changes from 3 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,259 @@ | ||
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
// SPDX-License-Identifier: MIT | ||
|
||
module "common" { | ||
source = "../../../common" | ||
} | ||
|
||
module "basic_components" { | ||
source = "../../../basic_components" | ||
|
||
region = var.region | ||
} | ||
|
||
data "aws_eks_cluster_auth" "this" { | ||
name = aws_eks_cluster.this.name | ||
} | ||
|
||
resource "aws_eks_cluster" "this" { | ||
name = "cwagent-eks-integ-${module.common.testing_id}" | ||
role_arn = module.basic_components.role_arn | ||
version = var.k8s_version | ||
enabled_cluster_log_types = [ | ||
"api", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we need these? Not sure what these do There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Tried running the setup without these and still works. I think these provide control plane logs from EKS under |
||
"audit", | ||
"authenticator", | ||
"controllerManager", | ||
"scheduler" | ||
] | ||
vpc_config { | ||
subnet_ids = module.basic_components.public_subnet_ids | ||
security_group_ids = [module.basic_components.security_group] | ||
} | ||
} | ||
|
||
# EKS Node Groups | ||
resource "aws_eks_node_group" "this" { | ||
cluster_name = aws_eks_cluster.this.name | ||
node_group_name = "cwagent-eks-integ-node-${module.common.testing_id}" | ||
node_role_arn = aws_iam_role.node_role.arn | ||
subnet_ids = module.basic_components.public_subnet_ids | ||
|
||
scaling_config { | ||
desired_size = 1 | ||
max_size = 1 | ||
min_size = 1 | ||
} | ||
|
||
ami_type = var.ami_type | ||
capacity_type = "ON_DEMAND" | ||
disk_size = 20 | ||
instance_types = [var.instance_type] | ||
|
||
depends_on = [ | ||
aws_iam_role_policy_attachment.node_AmazonEC2ContainerRegistryReadOnly, | ||
aws_iam_role_policy_attachment.node_AmazonEKS_CNI_Policy, | ||
aws_iam_role_policy_attachment.node_AmazonEKSWorkerNodePolicy, | ||
aws_iam_role_policy_attachment.node_CloudWatchAgentServerPolicy, | ||
aws_iam_role_policy_attachment.node_AWSXRayDaemonWriteAccess | ||
] | ||
} | ||
|
||
# EKS Node IAM Role | ||
resource "aws_iam_role" "node_role" { | ||
name = "cwagent-eks-Worker-Role-${module.common.testing_id}" | ||
|
||
assume_role_policy = <<POLICY | ||
{ | ||
"Version": "2012-10-17", | ||
"Statement": [ | ||
{ | ||
"Effect": "Allow", | ||
"Principal": { | ||
"Service": "ec2.amazonaws.com" | ||
}, | ||
"Action": "sts:AssumeRole" | ||
} | ||
] | ||
} | ||
POLICY | ||
} | ||
|
||
resource "aws_iam_role_policy_attachment" "node_AmazonEKSWorkerNodePolicy" { | ||
policy_arn = "arn:aws:iam::aws:policy/AmazonEKSWorkerNodePolicy" | ||
role = aws_iam_role.node_role.name | ||
} | ||
|
||
resource "aws_iam_role_policy_attachment" "node_AmazonEKS_CNI_Policy" { | ||
policy_arn = "arn:aws:iam::aws:policy/AmazonEKS_CNI_Policy" | ||
role = aws_iam_role.node_role.name | ||
} | ||
|
||
resource "aws_iam_role_policy_attachment" "node_AmazonEC2ContainerRegistryReadOnly" { | ||
policy_arn = "arn:aws:iam::aws:policy/AmazonEC2ContainerRegistryReadOnly" | ||
role = aws_iam_role.node_role.name | ||
} | ||
|
||
resource "aws_iam_role_policy_attachment" "node_CloudWatchAgentServerPolicy" { | ||
policy_arn = "arn:aws:iam::aws:policy/CloudWatchAgentServerPolicy" | ||
role = aws_iam_role.node_role.name | ||
} | ||
resource "aws_iam_role_policy_attachment" "node_AWSXRayDaemonWriteAccess" { | ||
policy_arn = "arn:aws:iam::aws:policy/AWSXRayDaemonWriteAccess" | ||
role = aws_iam_role.node_role.name | ||
} | ||
|
||
# TODO: these security groups be created once and then reused | ||
# EKS Cluster Security Group | ||
resource "aws_security_group" "eks_cluster_sg" { | ||
name = "cwagent-eks-cluster-sg-${module.common.testing_id}" | ||
description = "Cluster communication with worker nodes" | ||
vpc_id = module.basic_components.vpc_id | ||
} | ||
|
||
resource "aws_security_group_rule" "cluster_inbound" { | ||
description = "Allow worker nodes to communicate with the cluster API Server" | ||
from_port = 443 | ||
protocol = "tcp" | ||
security_group_id = aws_security_group.eks_cluster_sg.id | ||
source_security_group_id = aws_security_group.eks_nodes_sg.id | ||
to_port = 443 | ||
type = "ingress" | ||
} | ||
|
||
resource "aws_security_group_rule" "cluster_outbound" { | ||
description = "Allow cluster API Server to communicate with the worker nodes" | ||
from_port = 1024 | ||
protocol = "tcp" | ||
security_group_id = aws_security_group.eks_cluster_sg.id | ||
source_security_group_id = aws_security_group.eks_nodes_sg.id | ||
to_port = 65535 | ||
type = "egress" | ||
} | ||
|
||
|
||
# EKS Node Security Group | ||
resource "aws_security_group" "eks_nodes_sg" { | ||
name = "cwagent-eks-node-sg-${module.common.testing_id}" | ||
description = "Security group for all nodes in the cluster" | ||
vpc_id = module.basic_components.vpc_id | ||
|
||
egress { | ||
from_port = 0 | ||
to_port = 0 | ||
protocol = "-1" | ||
cidr_blocks = ["0.0.0.0/0"] | ||
} | ||
} | ||
|
||
resource "aws_security_group_rule" "nodes_internal" { | ||
description = "Allow nodes to communicate with each other" | ||
from_port = 0 | ||
protocol = "-1" | ||
security_group_id = aws_security_group.eks_nodes_sg.id | ||
source_security_group_id = aws_security_group.eks_nodes_sg.id | ||
to_port = 65535 | ||
type = "ingress" | ||
} | ||
|
||
resource "aws_security_group_rule" "nodes_cluster_inbound" { | ||
description = "Allow worker Kubelets and pods to receive communication from the cluster control plane" | ||
from_port = 1025 | ||
protocol = "tcp" | ||
security_group_id = aws_security_group.eks_nodes_sg.id | ||
source_security_group_id = aws_security_group.eks_cluster_sg.id | ||
to_port = 65535 | ||
type = "ingress" | ||
} | ||
|
||
resource "null_resource" "clone_helm_chart" { | ||
provisioner "local-exec" { | ||
command = <<-EOT | ||
if [ ! -d "./helm-charts" ]; then | ||
git clone -b ${var.helm_chart_branch} https://github.com/aws-observability/helm-charts.git ./helm-charts | ||
fi | ||
EOT | ||
} | ||
} | ||
|
||
resource "helm_release" "aws_observability" { | ||
name = "amazon-cloudwatch-observability" | ||
chart = "./helm-charts/charts/amazon-cloudwatch-observability" | ||
namespace = "amazon-cloudwatch" | ||
create_namespace = true | ||
|
||
set { | ||
name = "clusterName" | ||
value = aws_eks_cluster.this.name | ||
} | ||
|
||
set { | ||
name = "region" | ||
value = "us-west-2" | ||
} | ||
depends_on = [ | ||
aws_eks_cluster.this, | ||
aws_eks_node_group.this, | ||
null_resource.clone_helm_chart] | ||
} | ||
|
||
resource "kubernetes_pod" "log_generator" { | ||
depends_on = [aws_eks_node_group.this] | ||
metadata { | ||
name = "log-generator" | ||
namespace = "default" | ||
} | ||
|
||
spec { | ||
container { | ||
name = "log-generator" | ||
image = "busybox" | ||
|
||
# Run shell script that generate a log line every second | ||
command = ["/bin/sh", "-c"] | ||
args = ["while true; do echo \"Log entry at $(date)\"; sleep 1; done"] | ||
} | ||
restart_policy = "Always" | ||
} | ||
} | ||
|
||
|
||
# Get the single instance ID of the node in the node group | ||
data "aws_instances" "eks_node" { | ||
depends_on = [ | ||
aws_eks_node_group.this | ||
] | ||
filter { | ||
name = "tag:eks:nodegroup-name" | ||
values = [aws_eks_node_group.this.node_group_name] | ||
} | ||
} | ||
|
||
# Retrieve details of the single instance to get private DNS | ||
data "aws_instance" "eks_node_detail" { | ||
depends_on = [ | ||
data.aws_instances.eks_node | ||
] | ||
instance_id = data.aws_instances.eks_node.ids[0] | ||
} | ||
|
||
resource "null_resource" "validator" { | ||
depends_on = [ | ||
aws_eks_node_group.this, | ||
helm_release.aws_observability, | ||
kubernetes_pod.log_generator | ||
] | ||
|
||
triggers = { | ||
always_run = timestamp() | ||
} | ||
|
||
provisioner "local-exec" { | ||
command = <<-EOT | ||
echo "Validating EKS logs for entity fields" | ||
cd ../../../.. | ||
go test ${var.test_dir} -timeout 1h -eksClusterName=${aws_eks_cluster.this.name} -computeType=EKS -v -eksDeploymentStrategy=DAEMON -instanceId=${data.aws_instance.eks_node_detail.instance_id} | ||
EOT | ||
} | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
// SPDX-License-Identifier: MIT | ||
|
||
provider "aws" { | ||
region = var.region | ||
} | ||
|
||
provider "kubernetes" { | ||
exec { | ||
api_version = "client.authentication.k8s.io/v1beta1" | ||
command = "aws" | ||
args = ["eks", "get-token", "--cluster-name", aws_eks_cluster.this.name] | ||
} | ||
host = aws_eks_cluster.this.endpoint | ||
cluster_ca_certificate = base64decode(aws_eks_cluster.this.certificate_authority.0.data) | ||
token = data.aws_eks_cluster_auth.this.token | ||
} | ||
|
||
provider "helm" { | ||
kubernetes { | ||
host = aws_eks_cluster.this.endpoint | ||
cluster_ca_certificate = base64decode(aws_eks_cluster.this.certificate_authority.0.data) | ||
exec { | ||
api_version = "client.authentication.k8s.io/v1beta1" | ||
args = ["eks", "get-token", "--cluster-name", aws_eks_cluster.this.name] | ||
command = "aws" | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
// SPDX-License-Identifier: MIT | ||
|
||
variable "region" { | ||
type = string | ||
default = "us-west-2" | ||
} | ||
|
||
variable "test_dir" { | ||
type = string | ||
default = "./test/entity" | ||
} | ||
|
||
variable "k8s_version" { | ||
type = string | ||
default = "1.30" | ||
} | ||
|
||
variable "ami_type" { | ||
type = string | ||
default = "AL2_x86_64" | ||
} | ||
|
||
variable "instance_type" { | ||
type = string | ||
default = "t3a.medium" | ||
} | ||
|
||
variable "helm_chart_branch" { | ||
type = string | ||
default = "main" | ||
} | ||
|
||
variable "cwagent_image_repo" { | ||
type = string | ||
default = "public.ecr.aws/cloudwatch-agent/cloudwatch-agent" | ||
} | ||
|
||
variable "cwagent_image_tag" { | ||
type = string | ||
default = "latest" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there no common terraform to create an eks cluster? seems like we have duplicate code here from our EKS integ tests...can we just reuse it and then apply the helm chart?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no common terraform to create EKS cluster. All terraform setups for each test under
terraform/eks
folder have their own cluster setup. I think your point is valid though, having a common code to avoid potential duplication is better but I think it's out of scope for this PR.