-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix metric_value_benchmark integration tests by using latest Kafka version in JMXKafka test #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musa-asad
changed the title
Increase duration to 5 minutes for JMX Kafka tests.
Use latest Kafka version.
Dec 2, 2024
lisguo
changed the title
Use latest Kafka version
Fix metric_value_benchmark integration tests by using latest Kafka version in JMXKafka test
Dec 2, 2024
lisguo
approved these changes
Dec 2, 2024
movence
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We have inconsistent results in our
metric_value_benchmark
tests. We fail on JMXKafka:https://github.com/aws/amazon-cloudwatch-agent/actions/runs/11959277199/job/33340857051
The root cause was that the endpoint,
https://dlcdn.apache.org/kafka/3.6.2/kafka_2.13-3.6.2.tgz
, was removed due to it being an older version.Description of changes
curl https://dlcdn.apache.org/kafka/ | grep -oP \"\\d\\.\\d\\.\\d\" | tail -1
to fetch the latest version and use that to pull thetgz
file.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Ran terraform locally:
Output: