Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding windows 2025 Test #446

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Adding windows 2025 Test #446

merged 7 commits into from
Dec 18, 2024

Conversation

Paramadon
Copy link
Contributor

@Paramadon Paramadon commented Dec 17, 2024

Description of the issue

This pr adds windows 2025 test to our test integration test.yml so that we can support windows 2025. Successful test run: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/12392785920/job/34592783580

Win-2016,2019,2022,2025 all have both passing and failing test but since some tests are passing that means the ami is working and that the test are failing which is out of scopr of this change.

Description of changes

How does this change address the problem?

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Describe what tests you have done.

@Paramadon Paramadon requested a review from a team as a code owner December 17, 2024 23:19
dricross
dricross previously approved these changes Dec 18, 2024
Copy link
Contributor

@okankoAMZ okankoAMZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to double check if those eks test work then I think good to merge

generator/test_case_generator.go Outdated Show resolved Hide resolved
generator/test_case_generator.go Outdated Show resolved Hide resolved
terraform/eks/daemon/fluent/windows/2025/main.tf Outdated Show resolved Hide resolved
terraform/eks/daemon/fluent/windows/2025/variables.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@okankoAMZ okankoAMZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Paramadon Paramadon merged commit f92b85b into main Dec 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants