Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Contrib To 0.98.0 #1147

Merged
merged 1 commit into from
May 2, 2024
Merged

Upgrade Contrib To 0.98.0 #1147

merged 1 commit into from
May 2, 2024

Conversation

sethAmazon
Copy link
Contributor

@sethAmazon sethAmazon commented Apr 24, 2024

Description of the issue

Contirb is 2 months out of date

Description of changes

Upgrade to contrib latest

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

https://github.com/aws/amazon-cloudwatch-agent/actions/runs/8897306725/job/24476932527

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@sethAmazon sethAmazon requested a review from a team as a code owner April 24, 2024 17:26
@sethAmazon sethAmazon marked this pull request as draft April 24, 2024 17:26
@sethAmazon sethAmazon force-pushed the upgrade-contrib-0.98.0 branch 3 times, most recently from 23b6ad6 to ac7491d Compare April 24, 2024 17:55
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 64.73%. Comparing base (96d4763) to head (ac7491d).
Report is 547 commits behind head on main.

Files Patch % Lines
plugins/inputs/prometheus/metrics_receiver.go 0.00% 3 Missing ⚠️
plugins/inputs/prometheus/start.go 25.00% 3 Missing ⚠️
translator/translate/otel/pipeline/translator.go 0.00% 2 Missing ⚠️
plugins/inputs/prometheus/metrics_type_handler.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1147      +/-   ##
==========================================
+ Coverage   57.58%   64.73%   +7.14%     
==========================================
  Files         370      450      +80     
  Lines       17548    21996    +4448     
==========================================
+ Hits        10105    14239    +4134     
- Misses       6848     7067     +219     
- Partials      595      690      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sethAmazon sethAmazon force-pushed the upgrade-contrib-0.98.0 branch 14 times, most recently from 93b0e58 to 90d23b7 Compare April 29, 2024 16:10
go.mod Show resolved Hide resolved
@sethAmazon sethAmazon force-pushed the upgrade-contrib-0.98.0 branch from 90d23b7 to aee34c1 Compare April 29, 2024 18:06
@sethAmazon sethAmazon force-pushed the upgrade-contrib-0.98.0 branch 2 times, most recently from 925aab7 to efb6f88 Compare April 30, 2024 15:14
@sethAmazon sethAmazon marked this pull request as ready for review April 30, 2024 15:40
JayPolanco
JayPolanco previously approved these changes May 1, 2024
Skip TestIntervalStats

Also Look At __address__ Label For Instance

Turn on exporter.xray.allowDot feature gate

Fix Caching Key For EKS And EC2 Integ Test
lisguo
lisguo previously approved these changes May 2, 2024
@sethAmazon sethAmazon merged commit 8382db8 into main May 2, 2024
12 checks passed
@sethAmazon sethAmazon deleted the upgrade-contrib-0.98.0 branch May 2, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants