Added LoggingExporter for AppSignals during translation time if debugging is enabled. #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefchien
reviewed
Apr 25, 2024
|
In the test section, can you add info of how you verify this works in a real usage? |
Used "DebugKey" instead of "Debug" for consistency. Co-authored-by: Jeffrey Chien <[email protected]>
musa-asad
requested review from
a team,
zhihonl and
jefchien
and removed request for
a team
lisguo
approved these changes
Apr 29, 2024
jefchien
approved these changes
Apr 29, 2024
| @@ -54,6 +55,10 @@ func (t *translator) Translate(conf *confmap.Conf) (*common.ComponentTranslators | |||
| translators.Processors.Set(resourcedetection.NewTranslator(resourcedetection.WithDataType(t.dataType))) | |||
| translators.Processors.Set(awsappsignals.NewTranslator(awsappsignals.WithDataType(t.dataType))) | |||
|
|
|||
| if enabled, _ := common.GetBool(conf, common.DebugLogging); enabled { | |||
There was a problem hiding this comment.
Still think there's risk to enabling this level of debug logging using the existing agent/debug field. We can determine if we need to change this before we release it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
There is no LoggingExporter for AppSignals during translation time.
When debugging is enabled, we want to add the LoggingExporter with detailed verbosity to the translated
yaml.Description of changes
During translation:
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
common_test.go,logging/translator_test.go, andappsignals/translator_test.go.common_test.gowas just run to ensure that unit test still works for the new changes incommon.go.logging/translator_test.gochecks to see if thelogging.gois set up correctly and sees if the agent key missing throws an error and if enabling debugging provides the correct yaml configuration for the loggingexporter.appsignals/translator_test.goincludes a new check to see if the loggingexporter is appropriately added to the exporters when both appsignals and debugging are enabled.Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint