[Application Signals] Improve metric schema for EKS, Native K8s, EC2 #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrara
force-pushed
the
application_signals_ga
branch
from
23f6922 to
1885a95
Compare
This reverts commit 622dc67.
Merge as the changes have been reviewed in the previous PR.
bjrara
force-pushed
the
application_signals_ga
branch
from
3bc133f to
3ddb83b
Compare
lisguo
reviewed
May 17, 2024
plugins/processors/awsapplicationsignals/internal/normalizer/attributesnormalizer_test.go
Outdated
Show resolved
Hide resolved
plugins/processors/awsapplicationsignals/internal/resolver/attributesresolver.go
Show resolved
Hide resolved
plugins/processors/awsapplicationsignals/internal/resolver/attributesresolver.go
Outdated
Show resolved
Hide resolved
plugins/processors/awsapplicationsignals/internal/resolver/kubernetes.go
Show resolved
Hide resolved
lisguo
previously approved these changes
May 17, 2024
|
Let's change the PR title to something like "[Application SIgnals] Improve metric schema for EKS, Native K8s, EC2". |
bjrara
changed the title
lisguo
approved these changes
May 20, 2024
lisguo
changed the title
jefchien
approved these changes
May 20, 2024
plugins/processors/awsapplicationsignals/internal/normalizer/attributesnormalizer.go
Show resolved
Hide resolved
plugins/processors/awsapplicationsignals/internal/normalizer/attributesnormalizer_test.go
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Merge Application Signals changes to main.
Description of changes
Changes are described in umbrella PR: #1133.
Before the PR is merged, please make sure:
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Describe what tests you have done.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint