Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nvidia gpu count metrics and bugfix #1183

Merged
merged 5 commits into from
May 29, 2024
Merged

nvidia gpu count metrics and bugfix #1183

merged 5 commits into from
May 29, 2024

Conversation

movence
Copy link
Contributor

@movence movence commented May 21, 2024

Description of changes

This PR includes 1 bug fix and and enhancement to add NVIDIA GPU count metrics including _limit, _request and _total at pod, node and cluster levels

  • GPU count metrics
    • Add NVIDIA GPU count metric replication logic to metricstrasformprocessor translator
    • Update AWS EMF exporter metric declarations to include GPU count metrics with dimensions
  • Bug fix
    • Fix the bug where the agent emits pod GPU metrics when there is no active workload

Related PR in contrib: amazon-contributing/opentelemetry-collector-contrib#214

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Tested with a cluster with 2 GPU (g4dn.12xlarge) instances with a workload which requires 2 GPU devices out of 8 total. As shown in the graph.

  • Bug fix

    • Metrics showing wrong average pod_gpu_utilization of 25% when there is only 1 active workload using 2 GPU devices out of 8 total. This is because unused GPU devices still emit 0 utilization data.
      Screenshot 2024-05-21 at 11 12 43 AM
    • Metrics showing 100% with the fix.
      Screenshot 2024-05-21 at 11 29 44 AM
  • GPU count metrics

Screenshot 2024-05-20 at 12 11 21 PM

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@movence movence requested a review from a team as a code owner May 21, 2024 15:31
Copy link
Contributor

@Paramadon Paramadon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@movence movence merged commit 6d69782 into aws:main May 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants