Expand JMX configuration options in JSON schema #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jefchien
force-pushed
the
jmx-container-schema
branch
from
520ff16 to
296c249
Compare
sky333999
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
As part of an effort to support JMX on container environments, we need to expand the configuration to allow for JMX configurations within Application Signals and Container Insights.
Description of changes
Updates the JSON schema to support the new configuration. See
translator/config/sampleSchema/validLogsWithJMX.jsonfor sample valid configuration.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Adds tests for the schema.
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint