Refactor DBUser attribute #1245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjrara
reviewed
Jul 11, 2024
| @@ -40,7 +44,6 @@ var attributesRenamingForMetric = map[string]string{ | |||
| attr.AWSRemoteTarget: common.MetricAttributeRemoteResourceIdentifier, | |||
| attr.AWSRemoteResourceIdentifier: common.MetricAttributeRemoteResourceIdentifier, | |||
| attr.AWSRemoteResourceType: common.MetricAttributeRemoteResourceType, | |||
| attr.AWSRemoteDbUser: common.MetricAttributeRemoteDbUser, | |||
There was a problem hiding this comment.
attributesRenamingForMetric is created to maintain the list of attributes to be renamed for attributes in EMF logs, so keeping AttributeRemoteDbUser here is ok. But now I see how much confusion it caused from the current naming.
There was a problem hiding this comment.
In that case, I'll close this pull request if it's fine with you?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Refactor DBUser attribute
Description of changes
Refactor DBUser attribute
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Ran below commands, succeeded without errors.
make buildRequirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint