Add windows event log service restart detection and resubscribe #1259
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Currently, if the Windows
EventLog
service crashes and gets restarted, the CloudWatch agent no longer picks up events. This is because the event handle used by the subscription is no longer valid. The CloudWatch agent needs a way to detect that the service has restarted and then re-open the subscription.Description of changes
Adds a service monitor that uses the golang.org/x/sys/windows/svc/mgr package to periodically (every 10 seconds) detect if the
eventlog
service's PID has changed. If it has changed, it notifies each of thewineventlog
subscriptions to re-subscribe. This prevents the plugin from trying to re-subscribe if the service is down.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Added a unit test. Deployed build to Windows 2022 instance and manually stopped the
EventLog
service through the task manager. After restarting the service:Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint