Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate build jobs for artifacts and trigger tests with workflow_run #1269

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

jefchien
Copy link
Contributor

@jefchien jefchien commented Aug 2, 2024

Description of the issue

The integration-test.yml workflow has exceeded the reusable workflow limit of 20 (https://docs.github.com/en/enterprise-cloud@latest/actions/using-workflows/reusing-workflows#limitations) due to changes in the nested reusable workflows in the application-signals-e2e-test.yml workflow and no longer runs (https://github.com/aws/amazon-cloudwatch-agent/actions/runs/10221982238).

Invalid workflow file: .github/workflows/integration-test.yml#L1 too many workflows are referenced, total: 25, limit: 20

There isn't currently a way to increase the limit.

Description of changes

One way around this limitation is to move the application signals E2E workflow out of the integration test workflow. The build jobs that were previously in the integration test workflow have been separated out into their own workflow since both test workflows rely on the build artifacts for the commit. The test workflows are now triggered on the build workflow completion and success.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Triggered the build with a PR event (https://github.com/aws/amazon-cloudwatch-agent/actions/runs/10222942184?pr=1269), but am unable to test the workflow_run

Note: This event will only trigger a workflow run if the workflow file is on the default branch.

https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_run

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@jefchien jefchien requested a review from a team as a code owner August 2, 2024 22:43
@jefchien jefchien merged commit dab6b24 into main Aug 5, 2024
6 checks passed
@jefchien jefchien deleted the move-appsignals-tests branch August 5, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants