[chore] Replace workflow_run with workflow_dispatch #1274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
The
workflow_runevent doesn't provide the necessary context to run on non-default branches. This makes it difficult to test changes prior to merging the code and doesn't prevents concurrent runs.Description of changes
Switches to the
workflow_dispatchevent for the dependent tests and uses the GitHub CLIworkflow runcommand to start them. Each of the tests will now use the GitHub CLIrun viewcommand to check if the build-test-artifacts run has succeeded.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Did some tests on my fork to ensure that the commands work.
build-test-artifacts: https://github.com/jefchien/amazon-cloudwatch-agent/actions/runs/10270204377/job/28417408531integration-test: https://github.com/jefchien/amazon-cloudwatch-agent/actions/runs/10270206563/job/28417415360Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint