Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix integration tests workflow to validate SHAs match #1282

Merged
merged 5 commits into from
Aug 8, 2024

Conversation

jefchien
Copy link
Contributor

@jefchien jefchien commented Aug 8, 2024

Description of the issue

The GitHub CLI workflow runs the command based off of a branch. If another commit is merged into main before the workflow runs, then that new commit will be triggered by the build completing.

Description of changes

  • Validates that the SHAs match and stops the test if they don't.
  • Only run the application_signals E2E test if the build is for the main branch since that workflow only runs against main.
  • Runs on RELEASE_NOTES change

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

https://github.com/aws/amazon-cloudwatch-agent/actions/runs/10307755948
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/10308001488/job/28534467287

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@jefchien jefchien requested a review from a team as a code owner August 8, 2024 19:08
@jefchien jefchien merged commit c3f1e5f into main Aug 8, 2024
6 checks passed
@jefchien jefchien deleted the match-sha branch August 8, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants