Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End-to-End Build Workflow #1416

Merged
merged 12 commits into from
Dec 13, 2024
Merged

End-to-End Build Workflow #1416

merged 12 commits into from
Dec 13, 2024

Conversation

okankoAMZ
Copy link
Contributor

@okankoAMZ okankoAMZ commented Nov 8, 2024

Description of the issue

Allows us to build and test with operator for full end-to-end testing

Description of changes

Added new workflow to build agent and operator together

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Build Test Artifacts
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/11748578760
Example of workflow call working as intended for BuildArtifacts: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/12321954899

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@okankoAMZ okankoAMZ marked this pull request as ready for review November 8, 2024 20:12
@okankoAMZ okankoAMZ requested a review from a team as a code owner November 8, 2024 20:12
musa-asad
musa-asad previously approved these changes Nov 8, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label Nov 19, 2024
@github-actions github-actions bot removed the Stale label Nov 26, 2024
Comment on lines 7 to 8
ECR_TARGET_ALLOCATOR_STAGING_REPO: ${{ vars.ECR_TARGET_ALLOCATOR_STAGING_REPO}}
ECR_OPERATOR_RELEASE_IMAGE: ${{ vars.ECR_TARGET_ALLOCATOR_TEST_OPERATOR_REPO}}
Copy link
Contributor

@musa-asad musa-asad Dec 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these going to be used?

Copy link
Contributor

github-actions bot commented Dec 9, 2024

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label Dec 9, 2024
Copy link
Contributor

@musa-asad musa-asad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make these minor changes, otherwise it's good to go!

@TravisStark TravisStark self-requested a review December 13, 2024 20:48
@okankoAMZ okankoAMZ merged commit ad90d9e into main Dec 13, 2024
293 of 335 checks passed
@okankoAMZ okankoAMZ deleted the e2c-build-workflow branch December 13, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants