-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new OTel pipeline for scraping Kueue metrics and publishing to CloudWatch #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rohan Gujarathi <[email protected]>
Co-authored-by: Rohan Gujarathi <[email protected]>
Co-authored-by: Rohan Gujarathi <[email protected]>
…sights is true test: add unit tests for ``awscontainerinsights/translator.go``
this will need to be replaced with a real version when merged into public repos
condition is guaranteed to be true in that block of the code
chadpatel
reviewed
Nov 14, 2024
sky333999
reviewed
Nov 14, 2024
sky333999
reviewed
Nov 14, 2024
chadpatel
approved these changes
Nov 14, 2024
sky333999
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
As title says. This PR implements a new translator pipeline for collecting Kueue metrics and exporting them to CloudWatch.
The pipeline uses:
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Added unit testing for new components, updated unit testing for existing ones.
Integration tests in a separate PR.
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint