Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure SSH Keep Alive #1459

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Configure SSH Keep Alive #1459

wants to merge 2 commits into from

Conversation

musa-asad
Copy link
Contributor

Description of the issue

Some of our metric_value_benchmark tests for EC2Linux fail since the test takes too long to run.

│ Error: remote-exec provisioner error
│ 
│   with null_resource.integration_test_run,
│   on main.tf line 86, in resource "null_resource" "integration_test_run":
│   86:   provisioner "remote-exec" {
│ 
│ error executing "/tmp/terraform_XXXXXXXXXX.sh": wait: remote command exited
│ without exit status or exit signal

Description of changes

  • Add Configure SSH Keep Alive step for EC2 to send a keep-alive signal for all SSH hosts.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Ran workflow: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/12176145545.

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@musa-asad musa-asad self-assigned this Dec 5, 2024
@@ -13,7 +13,7 @@ env:
ECR_INTEGRATION_TEST_REPO: "cwagent-integration-test"
CWA_GITHUB_TEST_REPO_NAME: "aws/amazon-cloudwatch-agent-test"
CWA_GITHUB_TEST_REPO_URL: "https://github.com/aws/amazon-cloudwatch-agent-test.git"
CWA_GITHUB_TEST_REPO_BRANCH: "main"
CWA_GITHUB_TEST_REPO_BRANCH: "ssh-keep-alive"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will change after testing.

Suggested change
CWA_GITHUB_TEST_REPO_BRANCH: "ssh-keep-alive"
CWA_GITHUB_TEST_REPO_BRANCH: "main"

Copy link
Contributor

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant