-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement JMX E2E Tests in Testing Workflow #1463
Open
musa-asad
wants to merge
75
commits into
main
Choose a base branch
from
e2e-jmx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Musa <[email protected]>
varunch77
previously approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit/nonblocking comment: the names for the two test files could be made more clear/better reflect their purpose
dricross
previously approved these changes
Dec 17, 2024
TravisStark
previously approved these changes
Dec 18, 2024
musa-asad
dismissed stale reviews from TravisStark, varunch77, and dricross
via
December 18, 2024 23:24
2c74c4f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
The CloudWatch Agent now supports JMX metrics on EKS. We need to add testing to verify the behavior for JMX metrics collection in EKS environments.
Description of changes
Co-PR: aws/amazon-cloudwatch-agent-test#443.
EKSE2EJVMTomcatTest
,EKSE2EKafkaTest
, andEKSE2EJMXContainerInsightsTest
jobs in order to run testing for those configurations.matrix.arrays.nodes
as a value for Terraform to use.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
View Workflow Run #12368011112
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint