Case insensitive service provider

[chadpatel]

Description of the issue

The application, app and service service name provider ec2 tags are currently case sensitive, there are also bugs in exactness in how these are being compared due to excessive use of strings.Contains

Description of changes

Update InstanceTags to return a []string with the tag keys instead of the raw newline delimited list. This is a more friendly API to reason about. We can then convert it to a map with lowercase keys that we use for comparison.

I also fixed the asg lookup to also be an exact match instead. These matches are relatively efficient as I am converting the arrays to maps for O(1) lookups instead of having to repeatedly loop through the whole strings using Contains or slices.Contains

Related to: #1474

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Unit tests updated

Pooja tested manually for me on her cluster

Key
	
Value

APPLICATION
poojardy_test_application

Field	Value
@entity.Attributes.AWS.ServiceNameSource	
ResourceTags
@entity.Attributes.EC2.AutoScalingGroup	
asg-compass
@entity.Attributes.EC2.InstanceId	
i-0b6fe6aab9e76873b
@entity.Attributes.PlatformType	
AWS::EC2
@entity.KeyAttributes.Environment	
ec2:asg-compass
@entity.KeyAttributes.Name	
poojardy_test_application
@entity.KeyAttributes.Type	
Service
@ingestionTime	
1734719476173
@log	
957688854012:agent_log_group
@logStream	
agent_log_stream
@message	
2024-12-20T18:31:14Z I! CWAGENT_LOG_LEVEL is set to "DEBUG"
@timestamp	
1734719475179

Key
	
Value

APP
app_testing

1
2024-12-20T18:34:55.016Z
2024-12-20T18:34:53Z D! [logagent] open file count, 1
Field	Value
@entity.Attributes.AWS.ServiceNameSource	
ResourceTags
@entity.Attributes.EC2.AutoScalingGroup	
asg-compass
@entity.Attributes.EC2.InstanceId	
i-0b6fe6aab9e76873b
@entity.Attributes.PlatformType	
AWS::EC2
@entity.KeyAttributes.Environment	
ec2:asg-compass
@entity.KeyAttributes.Name	
app_testing
@entity.KeyAttributes.Type	
Service
@ingestionTime	
1734719695505
@log	
957688854012:agent_log_group
@logStream	
agent_log_stream
@message	
2024-12-20T18:34:53Z D! [logagent] open file count, 1
@timestamp	
1734719695016

Requirements

Before commit the code, please do the following steps.

1. Run make fmt and make fmt-sh -- done
2. Run make lint