cadvisor: Fix pod detection for containerd runtime on k8s #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With proper sock mounting, some path still got empty label and we should not generate warning error message.
pxaws
reviewed
Mar 22, 2021
| @@ -140,6 +140,9 @@ spec: | |||
| - name: varlibdocker | |||
| mountPath: /var/lib/docker | |||
| readOnly: true | |||
| - name: containerdsock | |||
There was a problem hiding this comment.
Just want to mention that the yaml files should also be updated in another repo: https://github.com/aws-samples/amazon-cloudwatch-container-insights
It's a bit annoying ... but it helps when user turn on debug log
* Skip diskio because we only extract node disk io
Existing targets build binary for all platforms, but for debugging container related problems, most time we only need some binaries for amd64.
pingleig
changed the title
Must have deleted it by accident when cleaning up the logs
pxaws
approved these changes
Mar 24, 2021
pingleig
added a commit
to pingleig/amazon-cloudwatch-container-insights
that referenced
this pull request
Apr 22, 2021
pingleig
added a commit
to aws-samples/amazon-cloudwatch-container-insights
that referenced
this pull request
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
Fix #188 k8s cluster using containerd runtime was not able to get pod metrics because
Description of changes
TypeInfraContainerand remove most usage onPODcontainer name.kubernetes>docker>container_idnot sure if it is used by any place (it comes from k8s api server though, not cadvisor), just use containerd in json path when it is containerdcontainer_filesystem_utilizationis missing in structured log [k8s][containerd] container file system metrics is not supported by cadvisor for contianerd #192, it's known issue in cadviisor.License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests