-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Container insights ssl #822
Conversation
Mind updating the title and the description of the PR to be provide some more details. Also, how did we verify that this fix works? |
Firstly, can you please update the PR title? It doesn't properly convey what this code change is for. The PR looks good but I think it's lacking some end-to-end testing. Unit testing isn't enough here. Can you build the agent with this code change and validate it yourself? |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #822 +/- ##
==========================================
+ Coverage 57.58% 62.43% +4.85%
==========================================
Files 370 339 -31
Lines 17548 17110 -438
==========================================
+ Hits 10105 10683 +578
+ Misses 6848 5873 -975
+ Partials 595 554 -41
☔ View full report in Codecov by Sentry. |
There are merge conflicts that you should resolve in your PR before it can be merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some evidence of manual testing to verify that this change works
This PR was marked stale due to lack of activity. |
We ran integration tests that are failing in some os and passing in others. The failures are for reasons apart from SSL connection. |
This PR was marked stale due to lack of activity. |
Description of the issue
In ccwa emf uses an otel exporter instead of a cwa exporter. We need to test this still works with ca bundle or not.
Description of changes
Here we are testing the container insights to check whether it works with the ca_bundle or not.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Unit tests passed
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint