Update OTel fork components to dd840b7a79ba22aca7bda3af5cb925ea208c1dc6 #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
chadpatel
requested review from
mitali-salvi and
sky333999
and removed request for
sky333999
chadpatel
previously approved these changes
Sep 25, 2023
| replace github.com/amazon-contributing/opentelemetry-collector-contrib/override/aws => github.com/amazon-contributing/opentelemetry-collector-contrib/override/aws v0.0.0-20230906164155-ced73ba61d63 | ||
| replace github.com/amazon-contributing/opentelemetry-collector-contrib/override/aws => github.com/amazon-contributing/opentelemetry-collector-contrib/override/aws v0.0.0-20230922200107-dd840b7a79ba | ||
|
|
||
| replace github.com/amazon-contributing/opentelemetry-collector-contrib/pkg/stanza => github.com/amazon-contributing/opentelemetry-collector-contrib/pkg/stanza v0.0.0-20230922200107-dd840b7a79ba |
There was a problem hiding this comment.
I manually moved this here because the workflow put it at the bottom of the file
mitali-salvi
previously approved these changes
Sep 25, 2023
chadpatel
dismissed stale reviews from mitali-salvi and themself
via
8aa5423
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #862 +/- ##
==========================================
+ Coverage 57.58% 62.22% +4.63%
==========================================
Files 370 339 -31
Lines 17548 17004 -544
==========================================
+ Hits 10105 10580 +475
+ Misses 6848 5871 -977
+ Partials 595 553 -42
☔ View full report in Codecov by Sentry. |
chadpatel
requested review from
mitali-salvi,
chadpatel and
zhihonl
and removed request for
chadpatel
zhihonl
approved these changes
Sep 25, 2023
mitali-salvi
approved these changes
Sep 26, 2023
sky333999
force-pushed
the
otel-fork-replace-dd840b7a79ba22aca7bda3af5cb925ea208c1dc6
branch
from
4006c92 to
d9bd0cb
Compare
chadpatel
deleted the
otel-fork-replace-dd840b7a79ba22aca7bda3af5cb925ea208c1dc6
branch
bhanuba
pushed a commit
that referenced
this pull request
Oct 2, 2023
Co-authored-by: Github Action <[email protected]> Co-authored-by: Chad Patel <[email protected]>
rvasahu-amazon
pushed a commit
to rvasahu-amazon/amazon-cloudwatch-agent
that referenced
this pull request
Nov 12, 2024
Co-authored-by: Rohan Gujarathi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
An automated PR to update the OTel fork components to point to dd840b7a79ba22aca7bda3af5cb925ea208c1dc6.
Additional necessary changes
replacein the go.mod to the top with the otherscadvisorandk8sapiserverinput plugins. This is dead code and the dead code was no longer building with the latest dependencies. Instead of fixing the build I deleted the dead codeLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
n/a
Requirements
Before commit the code, please do the following steps.
make fmtandmake fmt-shmake lint