Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update enhanced CI metrics and aggregations and update tests #866

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

chadpatel
Copy link
Contributor

Description of the issue

amazon-cloudawtch-agent update for this PR: amazon-contributing/opentelemetry-collector-contrib#96

Description of changes

  1. implement requested aggregations
  2. updated tests to pass, and also style fixes like unquoting imds_retries

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Tested end to end

Crash:
Screenshot 2023-09-20 at 2 22 51 PM

No crashes:
Screenshot 2023-09-20 at 10 18 55 AM

New kube-apiserver metrics
Screenshot 2023-09-20 at 2 54 57 PM

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@chadpatel chadpatel requested a review from a team as a code owner September 26, 2023 16:07
Copy link
Contributor

@SaxyPandaBear SaxyPandaBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chadpatel
Copy link
Contributor Author

pushing a rebase just so this is a bit more current

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (96d4763) 57.58% compared to head (78f4c67) 62.44%.
Report is 409 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
+ Coverage   57.58%   62.44%   +4.85%     
==========================================
  Files         370      339      -31     
  Lines       17548    17105     -443     
==========================================
+ Hits        10105    10681     +576     
+ Misses       6848     5871     -977     
+ Partials      595      553      -42     
Files Coverage Δ
cfg/commonconfig/commonconfig.go 8.00% <ø> (ø)
...md/amazon-cloudwatch-agent-config-wizard/wizard.go 59.55% <ø> (-8.51%) ⬇️
...amazon-cloudwatch-agent/amazon-cloudwatch-agent.go 2.68% <ø> (ø)
...oudwatch-agent/register_event_logger_notwindows.go 0.00% <ø> (ø)
...-cloudwatch-agent/register_event_logger_windows.go 0.00% <ø> (ø)
cmd/config-translator/translator.go 0.00% <ø> (ø)
cmd/xray-migration/commands_unix.go 42.50% <ø> (ø)
cmd/xray-migration/commands_windows.go 42.50% <ø> (ø)
cmd/xray-migration/xray-migration.go 30.28% <ø> (ø)
handlers/agentinfo/info.go 84.94% <ø> (ø)
... and 22 more

... and 206 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chadpatel chadpatel merged commit bf613bb into aws:main Sep 29, 2023
6 checks passed
rvasahu-amazon pushed a commit to rvasahu-amazon/amazon-cloudwatch-agent that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants