Pin github.com/mitchellh/mapstructure to v1.5.0 #872
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
With OTel upgrade to v0.84.0, it also upgraded
mapstructure
to v1.5.1 that brings along a change in behavior where empty slices overwrite the OTel defaults that would have been used when unmarshalling from yaml.An example is where the yaml generated via config translation typically has
service->telemetry->logs->output_paths
set to[]
and when initializing the OTel collector, the default is["stderr"]
.Post this change, the
[]
would overwrite the default["stderr"]
thus discarding all logs.As an example, unmarshalling the following into an OTel.Config with v1.5.0 results in
output_paths
being set to the default i.e.["stderr"]
. But doing the same with v1.5.1 results inoutput_paths
being set to[]
.Description of changes
Pinning
mapstructure
to the prior version. No major changes between v1.5.0 and v1.5.1License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint