Filter terminated pods from node request metrics. #882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
The
node_<cpu|memory>_request
metrics and metrics derived from them (node_<cpu|memory>_reserved_capacity
) differ from the output ofkubectl describe node <node_name>
. This is because kubectl filters out terminated pods. See open-telemetry/opentelemetry-collector-contrib#27262 for more details.Bumps the contrib dependencies to include fix amazon-contributing/opentelemetry-collector-contrib#104.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
n/a
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint