Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter terminated pods from node request metrics. #882

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 2, 2023

Description of the issue

The node_<cpu|memory>_request metrics and metrics derived from them (node_<cpu|memory>_reserved_capacity) differ from the output of kubectl describe node <node_name>. This is because kubectl filters out terminated pods. See open-telemetry/opentelemetry-collector-contrib#27262 for more details.

Bumps the contrib dependencies to include fix amazon-contributing/opentelemetry-collector-contrib#104.

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

n/a

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@github-actions github-actions bot requested a review from a team as a code owner October 2, 2023 18:13
@jefchien jefchien changed the title Update OTel fork components to 1957d95a68c7d61bb5c3344e09439611a3977405 Filter terminated pods from node request metrics. Oct 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (96d4763) 57.58% compared to head (432391d) 62.44%.
Report is 415 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
+ Coverage   57.58%   62.44%   +4.85%     
==========================================
  Files         370      339      -31     
  Lines       17548    17105     -443     
==========================================
+ Hits        10105    10681     +576     
+ Misses       6848     5871     -977     
+ Partials      595      553      -42     
Files Coverage Δ
cfg/commonconfig/commonconfig.go 8.00% <ø> (ø)
...md/amazon-cloudwatch-agent-config-wizard/wizard.go 59.55% <ø> (-8.51%) ⬇️
...amazon-cloudwatch-agent/amazon-cloudwatch-agent.go 2.68% <ø> (ø)
...oudwatch-agent/register_event_logger_notwindows.go 0.00% <ø> (ø)
...-cloudwatch-agent/register_event_logger_windows.go 0.00% <ø> (ø)
cmd/config-translator/translator.go 0.00% <ø> (ø)
cmd/xray-migration/commands_unix.go 42.50% <ø> (ø)
cmd/xray-migration/commands_windows.go 42.50% <ø> (ø)
cmd/xray-migration/xray-migration.go 30.28% <ø> (ø)
handlers/agentinfo/info.go 84.94% <ø> (ø)
... and 22 more

... and 206 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jefchien jefchien merged commit f6bc8c0 into main Oct 5, 2023
@jefchien jefchien deleted the otel-fork-replace-1957d95a68c7d61bb5c3344e09439611a3977405 branch October 5, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants