Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update enhanced CI metrics and tests for pod_container_status metrics #899

Merged
merged 1 commit into from
Oct 10, 2023

Conversation

chadpatel
Copy link
Contributor

Description of the issue

Move to container status metrics
See amazon-contributing/opentelemetry-collector-contrib#109

Description of changes

Updated metrics/units:
Screenshot 2023-10-10 at 2 16 10 PM

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

tested end to end, see screenshots aove

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@chadpatel chadpatel requested a review from a team as a code owner October 10, 2023 20:08
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (96d4763) 57.58% compared to head (8d479a9) 62.41%.
Report is 423 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
+ Coverage   57.58%   62.41%   +4.82%     
==========================================
  Files         370      339      -31     
  Lines       17548    17107     -441     
==========================================
+ Hits        10105    10677     +572     
+ Misses       6848     5877     -971     
+ Partials      595      553      -42     
Files Coverage Δ
cfg/commonconfig/commonconfig.go 8.00% <ø> (ø)
...md/amazon-cloudwatch-agent-config-wizard/wizard.go 59.55% <ø> (-8.51%) ⬇️
...amazon-cloudwatch-agent/amazon-cloudwatch-agent.go 2.64% <ø> (ø)
...oudwatch-agent/register_event_logger_notwindows.go 0.00% <ø> (ø)
...-cloudwatch-agent/register_event_logger_windows.go 0.00% <ø> (ø)
cmd/config-translator/translator.go 0.00% <ø> (ø)
cmd/xray-migration/commands_unix.go 42.50% <ø> (ø)
cmd/xray-migration/commands_windows.go 42.50% <ø> (ø)
cmd/xray-migration/xray-migration.go 30.28% <ø> (ø)
handlers/agentinfo/info.go 84.94% <ø> (ø)
... and 22 more

... and 206 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chadpatel chadpatel merged commit fc6b1c5 into aws:main Oct 10, 2023
5 of 6 checks passed
@chadpatel chadpatel deleted the pod_container_status_metrics branch October 10, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants