-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify Building Procedure #904
Draft
okankoAMZ
wants to merge
15
commits into
main
Choose a base branch
from
uniform-build-env
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okankoAMZ
added
github_actions
Pull requests that update GitHub Actions code
go
Pull requests that update Go code
labels
Oct 12, 2023
okankoAMZ
force-pushed
the
uniform-build-env
branch
3 times, most recently
from
October 16, 2023 17:48
0d5a3dc
to
1bad86d
Compare
okankoAMZ
force-pushed
the
uniform-build-env
branch
from
October 16, 2023 17:50
1bad86d
to
2017a3f
Compare
okankoAMZ
force-pushed
the
uniform-build-env
branch
from
October 17, 2023 19:55
92edff2
to
82b8304
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
==========================================
+ Coverage 57.58% 62.96% +5.38%
==========================================
Files 370 325 -45
Lines 17548 16131 -1417
==========================================
+ Hits 10105 10157 +52
+ Misses 6848 5461 -1387
+ Partials 595 513 -82
☔ View full report in Codecov by Sentry. |
okankoAMZ
force-pushed
the
uniform-build-env
branch
7 times, most recently
from
October 18, 2023 20:54
009a5ae
to
9474556
Compare
okankoAMZ
force-pushed
the
uniform-build-env
branch
from
October 23, 2023 18:09
9474556
to
0a6f802
Compare
This PR was marked stale due to lack of activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
github_actions
Pull requests that update GitHub Actions code
go
Pull requests that update Go code
Stale
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We were testing and releasing the agent on different build environments, which causes parity issue between testing and release.
Description of changes
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Ran integration test
Requirements
Before commit the code, please do the following steps.
make fmt
andmake fmt-sh
make lint