Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Building Procedure #904

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Unify Building Procedure #904

wants to merge 15 commits into from

Conversation

okankoAMZ
Copy link
Contributor

Description of the issue

We were testing and releasing the agent on different build environments, which causes parity issue between testing and release.

Description of changes

  • Created Custom AMIs using EC2 image builder, which have built-in Lifecycles.
  • Wrote a script using aws-go-sdk-v2 that:
    • Finds latest custom AMIs
    • Launches EC2 instance with these AMIs
    • Run Commands on them using SSM
  • These commands builds and upload builds to S3

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Ran integration test

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@okankoAMZ okankoAMZ added github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code labels Oct 12, 2023
@okankoAMZ okankoAMZ self-assigned this Oct 12, 2023
@okankoAMZ okankoAMZ force-pushed the uniform-build-env branch 3 times, most recently from 0d5a3dc to 1bad86d Compare October 16, 2023 17:48
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (96d4763) 57.58% compared to head (0a6f802) 62.96%.
Report is 431 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
+ Coverage   57.58%   62.96%   +5.38%     
==========================================
  Files         370      325      -45     
  Lines       17548    16131    -1417     
==========================================
+ Hits        10105    10157      +52     
+ Misses       6848     5461    -1387     
+ Partials      595      513      -82     
Files Coverage Δ
cfg/commonconfig/commonconfig.go 8.00% <ø> (ø)
...md/amazon-cloudwatch-agent-config-wizard/wizard.go 50.56% <ø> (-17.50%) ⬇️
...amazon-cloudwatch-agent/amazon-cloudwatch-agent.go 2.64% <ø> (ø)
...oudwatch-agent/register_event_logger_notwindows.go 0.00% <ø> (ø)
cmd/config-translator/translator.go 0.00% <ø> (ø)
cmd/xray-migration/commands_unix.go 42.50% <ø> (ø)
cmd/xray-migration/xray-migration.go 28.87% <ø> (ø)
handlers/agentinfo/info.go 84.40% <ø> (ø)
internal/cloudwatch/unit.go 86.00% <ø> (ø)
internal/ecsservicediscovery/decoratedtask.go 87.23% <ø> (ø)
... and 19 more

... and 214 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@okankoAMZ okankoAMZ force-pushed the uniform-build-env branch 7 times, most recently from 009a5ae to 9474556 Compare October 18, 2023 20:54
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity.

@github-actions github-actions bot added the Stale label Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code go Pull requests that update Go code Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants