Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OTEL to v0.89.0 #990

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Bump OTEL to v0.89.0 #990

merged 1 commit into from
Dec 11, 2023

Conversation

jefchien
Copy link
Contributor

@jefchien jefchien commented Dec 8, 2023

Description of the issue

The contrib was bumped to v0.89.0 as part of amazon-contributing/opentelemetry-collector-contrib#141. The agent needs to be updated as well to take in those changes.

This allows us to take in some of the upstream fixes like the pkg/stanza/adapter panic fix.

Description of changes

Bumps the OTEL dependencies to v0.89.0.

  • Retains sampling configuration

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Tests

Ran the integration tests: https://github.com/aws/amazon-cloudwatch-agent/actions/runs/7133797881

Requirements

Before commit the code, please do the following steps.

  1. Run make fmt and make fmt-sh
  2. Run make lint

@jefchien jefchien requested a review from a team as a code owner December 8, 2023 19:22
@codecov-commenter
Copy link

codecov-commenter commented Dec 8, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (96d4763) 57.58% compared to head (ac35d56) 62.92%.
Report is 469 commits behind head on main.

Files Patch % Lines
cfg/aws/credentials.go 0.00% 22 Missing ⚠️
cfg/aws/shared_config.go 62.50% 15 Missing ⚠️
cfg/envconfig/envconfig.go 50.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
+ Coverage   57.58%   62.92%   +5.33%     
==========================================
  Files         370      359      -11     
  Lines       17548    18180     +632     
==========================================
+ Hits        10105    11439    +1334     
+ Misses       6848     6151     -697     
+ Partials      595      590       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jefchien jefchien merged commit c17c309 into main Dec 11, 2023
6 checks passed
@jefchien jefchien deleted the bump-v0.89.0 branch December 11, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants